Skip to content

Conversation

foxfirecodes
Copy link
Contributor

Social SDK counterpart to #7674 -- separated out so we can wait until Social SDK has been released to update those docs

@foxfirecodes foxfirecodes requested a review from a team as a code owner July 10, 2025 22:26
@foxfirecodes foxfirecodes requested review from markmandel and removed request for a team July 10, 2025 22:26
@foxfirecodes foxfirecodes changed the base branch from main to lew/add-url-and-status-display-rich-presence-fields July 10, 2025 22:28
Base automatically changed from lew/add-url-and-status-display-rich-presence-fields to main July 17, 2025 22:02
@colinloretz colinloretz added the not released This issue or PR is referencing a change that is not yet widely released and/or subject to change. label Jul 29, 2025
@foxfirecodes foxfirecodes force-pushed the lew/add-url-and-status-display-rich-presence-fields-social-sdk branch from 5482bab to 3ea989f Compare August 28, 2025 18:38
@@ -247,6 +247,46 @@ client->UpdateRichPresence(
```
---

## Setting Field URLs
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think both of these sections would be better just below ## Setting Assets since it flows naturally from there.

I am wondering though if that section should be ## Setting Predefined Assets and this should be something like ## Setting Rich Presence Clickable Links or something like that - that describes what you are doing.

What do you think of that?

Down here we're in ## Rich Presence Without Authentication which feels like the wrong section.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

im good with moving them! i think that makes sense

i'm like 70% sure that you can set more than just predefined assets so i dont think renaming that section is necessary. as for renaming the field URLs section, i think it's redundant to say Rich Presence when we're on the rich presence page but i'm open to maybe doing "Setting Clickable Links" if that feels more intuitive to you than "Setting Field URLs"

so in the meantime ive moved the section, but left the headers the same. lmk your thoughts on if you still think the header could be reworded

@markmandel markmandel removed the not released This issue or PR is referencing a change that is not yet widely released and/or subject to change. label Sep 3, 2025
Copy link
Contributor

@markmandel markmandel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just did a preview - looks great. I agree with keeping the section titles, good call 👍🏻

@markmandel markmandel merged commit ce65798 into main Sep 3, 2025
4 checks passed
@markmandel markmandel deleted the lew/add-url-and-status-display-rich-presence-fields-social-sdk branch September 3, 2025 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants