-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Document new rich presence url & status display type fields for Social SDK #7676
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document new rich presence url & status display type fields for Social SDK #7676
Conversation
5482bab
to
3ea989f
Compare
@@ -247,6 +247,46 @@ client->UpdateRichPresence( | |||
``` | |||
--- | |||
|
|||
## Setting Field URLs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think both of these sections would be better just below ## Setting Assets
since it flows naturally from there.
I am wondering though if that section should be ## Setting Predefined Assets
and this should be something like ## Setting Rich Presence Clickable Links
or something like that - that describes what you are doing.
What do you think of that?
Down here we're in ## Rich Presence Without Authentication
which feels like the wrong section.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
im good with moving them! i think that makes sense
i'm like 70% sure that you can set more than just predefined assets so i dont think renaming that section is necessary. as for renaming the field URLs section, i think it's redundant to say Rich Presence when we're on the rich presence page but i'm open to maybe doing "Setting Clickable Links" if that feels more intuitive to you than "Setting Field URLs"
so in the meantime ive moved the section, but left the headers the same. lmk your thoughts on if you still think the header could be reworded
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just did a preview - looks great. I agree with keeping the section titles, good call 👍🏻
Social SDK counterpart to #7674 -- separated out so we can wait until Social SDK has been released to update those docs